C++

frantic.^ · Mar 18, 2011

This program is designed to read the gender and GPA of each entry line in the input file, and then output the average GPA for males, and the average GPA for females in the output file.
=====================================================
Okay so I'm not getting any errors, but when the program runs, it appears to be broken..."Please enter any key to continue...".
Am I retrieving input from the input file incorrectly?
Or am I referencing incorrectly in my parameters of functions?
FYI...the input file is in the following format for gender followed by GPA:

Code:

f 4.0
m 3.5
f 2.0
m 1.3
.
.
.
{eof}

Code:

/*********************************************************************
    Name: Daniel Wilson
    Project: Lab_6_exercise_6 (GPA Problem)
    Date of Coding: 03/18/2011
    Course: C++ IST-163-201
    Instructor: Brian Morgan
    Help Recieved: c++ textbook,in-class discussions

**********************************************************************/

#include<iostream>
#include<iomanip>
#include<fstream>
#include<string>

using namespace std;

//function prototypes
int openFiles();
int getSex(istream& in);
double getGPA(istream& in);
void initialize(int& countFemale,int& countMale,double& sumFemaleGPA,double& sumMaleGPA);
void sumGrades(char sex,double gpa, int& countFemale, int& countMale, double& sumFemaleGPA, double& sumMaleGPA);
void averageGrade(int countFemale, int countMale, double sumFemaleGPA, double sumMaleGPA,double& averageFemaleGPA,double& averageMaleGPA);
void printResults(double averageFemaleGPA,double averageMaleGPA);


int main()
{
    int countFemale;
    int countMale;
    double sumFemaleGPA;
    double sumMaleGPA;
    double averageFemaleGPA;
    double averageMaleGPA;
    char sex;
    double gpa;
    ifstream fin;
	ofstream fout;
    
    initialize(countFemale,countMale,sumFemaleGPA,sumMaleGPA);
    openFiles();

	sex = (getSex(fin));
    gpa = getGPA(fin);
	while (!fin.eof())
	{
        sumGrades(sex,gpa,countFemale,countMale,sumFemaleGPA,sumMaleGPA);
		sex = getSex(fin);
        gpa = getGPA(fin);
	}
    
    averageGrade(countFemale,countMale,sumFemaleGPA,sumMaleGPA,averageFemaleGPA,averageMaleGPA);

	printResults(averageFemaleGPA,averageMaleGPA);

	fin.close();
	fout.close();

	return 0;
}

int openFiles()
{
    ifstream fin; //input stream variable for data
    ofstream fout; //output stream variable

    fin.open("inputdata.txt");

    if (!fin)
    {
        cout << "Unable to open the input file." << endl;
        cout << "This program terminates." << endl;
        return 1;
    }

    fout.open("out.txt");
    fout << fixed << showpoint;
    fout << setprecision(2);
}

int getSex(istream& in)
{
	char sex;
	in >> sex;
    return sex;
}

double getGPA(istream& in)
{
	double gpa;
	in >> gpa;
	return gpa;
}

void initialize(int& countFemale,int& countMale,double& sumFemaleGPA,double& sumMaleGPA)
{
    countFemale = 0;
    countMale = 0;
    sumFemaleGPA = 0.0;
    sumMaleGPA = 0.0;
}



void sumGrades(char sex,double gpa, int& countFemale, int& countMale, double& sumFemaleGPA, double& sumMaleGPA)
{
    
    if(sex == 'f')
    {
        countFemale++;
        sumFemaleGPA = sumFemaleGPA + gpa;
    }
    else 
    {
        countMale++;
        sumMaleGPA = sumMaleGPA + gpa;
    }
}

void averageGrade(int countFemale, int countMale, double sumFemaleGPA, double sumMaleGPA,double& averageFemaleGPA,double& averageMaleGPA)
{
    
    averageFemaleGPA = sumFemaleGPA / countFemale;
    averageMaleGPA = sumMaleGPA / countMale;
}

void printResults(double averageFemaleGPA,double averageMaleGPA)
{
    ofstream fout; //output stream variable
	
	fout << endl << "The average female GPA is " << averageFemaleGPA << "." << endl;
    fout << "The average male GPA is " << averageMaleGPA << "." << endl;
}

DragonD · Mar 19, 2011

Debugging 101, print out your values and see what ya got.

Code:

int getSex(istream& in)
{
	char sex;
	in >> sex;
[COLOR="Red"]
cout << "sex = " << sex << endl;[/COLOR]

    return sex;
}

frantic.^ · Mar 19, 2011

Okay so apparently I'm getting a value for the gender(sex) that, from my research, is an Extended ASCII Code with "HTML code 204", it essentially looks like a foreign symbol. My value for GPA is "-9.25596e + 061".

I changed my code around and made both the getSex and getGPA functions void functions, I think this has helped in a sense. I am now (while debugging) getting an infinite loop of the foreign symbol followed by "-9.25596e + 061". So this leads me to believe that my program is entering the while (!fin.eof()) loop in my main function, so this must mean that the problem is due to an error in reading the input file. I suppose my question is, why am I getting foreign values from my input file? when the input file reads:

Code:

f 4.0
m 2.0
f 3.5
m 4.0

frantic.^ · Mar 19, 2011

Here is the program that has changed the get functions to void:

Code:

#include<iostream>
#include<iomanip>
#include<fstream>
#include<string>

using namespace std;

//function prototypes
void openFiles();
void getSex(char& sex);
void getGPA(double& gpa);
void initialize(int& countFemale,int& countMale,double& sumFemaleGPA,double& sumMaleGPA);
void sumGrades(char sex,double gpa, int& countFemale, int& countMale, double& sumFemaleGPA, double& sumMaleGPA);
void averageGrade(int countFemale, int countMale, double sumFemaleGPA, double sumMaleGPA,double& averageFemaleGPA,double& averageMaleGPA);
void printResults(double averageFemaleGPA,double averageMaleGPA, ostream& out=cout);

int main()
{
    int countFemale;
    int countMale;
    double sumFemaleGPA;
    double sumMaleGPA;
    double averageFemaleGPA;
    double averageMaleGPA;
    char sexValue;
    double gpaValue;
    ifstream fin;
	ofstream fout;
    
    initialize(countFemale,countMale,sumFemaleGPA,sumMaleGPA);
    openFiles();

	if (!fin)
    {
        cout << "Unable to open the input file." << endl;
        cout << "This program terminates." << endl;
        return 1;
    }

	getSex(sexValue);
    getGPA(gpaValue);
	while (!fin.eof())
	{
		sumGrades(sexValue,gpaValue,countFemale,countMale,sumFemaleGPA,sumMaleGPA);
		getSex(sexValue);
        getGPA(gpaValue);
	}
    
    averageGrade(countFemale,countMale,sumFemaleGPA,sumMaleGPA,averageFemaleGPA,averageMaleGPA);

	printResults(averageFemaleGPA,averageMaleGPA);

	return 0;
}

void openFiles()
{
    ifstream fin; //input stream variable for data
    ofstream fout; //output stream variable

    fin.open("myinput.txt");
    fout.open("out.txt");
    
	fout << fixed << showpoint;
    fout << setprecision(2);
}

void getSex(char& sex)
{
	ifstream fin;
	fin >> sex;
}

void getGPA(double& gpa)
{
	ifstream fin;
	fin >> gpa;
	cout << "gpa = " << gpa << endl;
}

void initialize(int& countFemale,int& countMale,double& sumFemaleGPA,double& sumMaleGPA)
{
    countFemale = 0;
    countMale = 0;
    sumFemaleGPA = 0.0;
    sumMaleGPA = 0.0;
}



void sumGrades(char sex,double gpa, int& countFemale, int& countMale, double& sumFemaleGPA, double& sumMaleGPA)
{
    
    if(sex == 'f')
    {
        countFemale++;
        sumFemaleGPA = sumFemaleGPA + gpa;
    }
    else 
    {
        countMale++;
        sumMaleGPA = sumMaleGPA + gpa;
    }
}

void averageGrade(int countFemale, int countMale, double sumFemaleGPA, double sumMaleGPA,double& averageFemaleGPA,double& averageMaleGPA)
{
    
    averageFemaleGPA = sumFemaleGPA / countFemale;
    averageMaleGPA = sumMaleGPA / countMale;
}

void printResults(double averageFemaleGPA,double averageMaleGPA, ostream& out)
{	
	out << endl << "The average female GPA is " << averageFemaleGPA << "." << endl;
    out << "The average male GPA is " << averageMaleGPA << "." << endl;
}

DragonD · Mar 20, 2011

Sorry, I've been out of town.

Did you figure it out?

C++

frantic.^

Famous

DragonD

The Division of None

frantic.^

Famous

frantic.^

Famous

DragonD

The Division of None

Latest posts