Resolved CS:GO - Jailbreak - Incorrect Message Appears on Max Nominations

[Jacko]

Bug Reports​

What application are you reporting this issue on?

CS:GO
​

Short description of the problem (255 char limit)

Incorrect Message Appears on Max Nominations
​

What server are you reporting this issue on?

Jailbreak
​

Please describe the issue in as much detail as possible.

When max number of maps are nominated an incorrect message displays saying "[SM] The map you chose has already been nominated."
​

What should be happening instead?

Instead of saying that it should saying something along the lines of "[SM] Maximum amount of Maps have already been nominated"
​

Please describe how to replicate the bug in as much detail as possible

Have players nominate a map then try nominating a map that has not been nominated already.
​

Any extra info we may need to know

Very low priority issue.
​

 

[thorgot]

I looked into this a few months ago and it's a sourcemod bug in the nominations plugin:

	if (result > Nominate_Replaced)
	{
		if (result == Nominate_AlreadyInVote)
		{
			ReplyToCommand(client, "%t", "Map Already In Vote", displayName);
		}
		else
		{
			ReplyToCommand(client, "[SM] %t", "Map Already Nominated"); // <---- wrong translation string
		}
		
		return Plugin_Handled;	
	}

so to fix this permanently I've opened up a PR with them here.

tldr: It is out of our hands, it's a sourcemod bug, but I've submitted a fix that they'll hopefully use.

 

[Jacko]

I looked into this a few months ago and it's a sourcemod bug in the nominations plugin:

	if (result > Nominate_Replaced)
	{
		if (result == Nominate_AlreadyInVote)
		{
			ReplyToCommand(client, "%t", "Map Already In Vote", displayName);
		}
		else
		{
			ReplyToCommand(client, "[SM] %t", "Map Already Nominated"); // <---- wrong translation string
		}
		
		return Plugin_Handled;	
	}

so to fix this permanently I've opened up a PR with them here.

tldr: It is out of our hands, it's a sourcemod bug, but I've submitted a fix that they'll hopefully use.

Good to know, thanks for looking into it my dude.

 

[Drewerth]

Closed.

There's no telling how long it'll take AM to include the patch but there's no need to keep this thread here; it's effectively handled.